Skip to content

Uncomment code and add info #11739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2019
Merged

Uncomment code and add info #11739

merged 1 commit into from
Jun 14, 2019

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark added this to the 3.4 milestone Jun 13, 2019
@javiereguiluz
Copy link
Member

I don't like the original content ... but I'm not fan either of the proposal based on "diff" (because it makes the example too long). Here's another proposal for your consideration:

  1. Uncomment the addPart() code
  2. Add something like this comment above that code: // you can remove the following code if you don't define a text version for your emails

@OskarStark
Copy link
Contributor Author

Thanks Javier, I really like your feedback and will rework it 👍🏻

@OskarStark OskarStark force-pushed the use-diff-for-plaintext branch 2 times, most recently from 8f13821 to a9d7fea Compare June 14, 2019 11:20
@OskarStark OskarStark requested a review from javiereguiluz June 14, 2019 11:20
@OskarStark OskarStark force-pushed the use-diff-for-plaintext branch from a9d7fea to d31baa3 Compare June 14, 2019 11:31
@OskarStark OskarStark force-pushed the use-diff-for-plaintext branch from d31baa3 to d78f17d Compare June 14, 2019 11:31
@OskarStark OskarStark changed the title Use diff instead of code comment Uncomment code and add info Jun 14, 2019
@OskarStark OskarStark requested a review from xabbuh June 14, 2019 11:31
@javiereguiluz
Copy link
Member

Thank you Oskar.

@javiereguiluz javiereguiluz merged commit d78f17d into symfony:3.4 Jun 14, 2019
javiereguiluz added a commit that referenced this pull request Jun 14, 2019
@javiereguiluz
minor #11739 Uncomment code and add info (OskarStark)
b7886aa 
This PR was merged into the 3.4 branch.

Discussion
----------

Uncomment code and add info

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

d78f17d Uncomment code and add info
@OskarStark OskarStark deleted the use-diff-for-plaintext branch June 14, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Mailer Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @javiereguiluz @carsonbot